Remove genclient:Namespaced tag
#749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tag isn't used by controller-tools, only `nonNamespaced` is. Context: https://cloud-native.slack.com/archives/CLAJ40HV3/p1708794732147909 Tested by running `make generate` and verifying that there is no diff. Signed-off-by: Georg Molau [[email protected]](mailto:[email protected]) Signed-off-by: Georg Molau <[email protected]>
|
@gmolau can you please create an issue in flux2 for this task then link all the PRs to it. This way we don't lose track of them all. |
|
@stefanprodan Sure, here fluxcd/flux2#4634 (I'm waiting for all CIs to pass before opening the PRs now.) |
stefanprodan
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tag isn't used by controller-tools, only
nonNamespacedis.Context: https://cloud-native.slack.com/archives/CLAJ40HV3/p1708794732147909
Tested by running
make generateand verifying that there is no diff.